fix(plugin-oracle): Switch to ALL_TAB_* as DBA_TAB* requires ADMIN pe… (#26554)

ScrapCodes · web-flow · commit 3c08e16aeb4a · 2025-11-11T12:31:10.000+05:30
…rmission ## Description https://docs.oracle.com/en/database/oracle/oracle-database/21/refrn/ALL_TAB_STATISTICS.html#GUID-C567F729-3748-4DFE-A22C-115CB7575D63 As per the docs above, DB_TAB_STATISTICS table requires admin privilage, whereas ALL_TAB_STATISTICS returns stats for tables accessible by current user. ## Motivation and Context Fixes a case where user does not have permission on DBA_TAB_STATISTICS table. ## Impact  ## Test Plan  ## Contributor checklist - [ ] Please make sure your submission complies with our [contributing guide](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md), in particular [code style](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#code-style) and [commit standards](https://github.com/prestodb/presto/blob/master/CONTRIBUTING.md#commit-standards). - [ ] PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced. - [ ] Documented new properties (with its default value), SQL syntax, functions, or other functionality. - [ ] If release notes are required, they follow the [release notes guidelines](https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines). - [ ] Adequate tests were added if applicable. - [ ] CI passed. - [ ] If adding new dependencies, verified they have an [OpenSSF Scorecard](https://securityscorecards.dev/#the-checks) score of 5.0 or higher (or obtained explicit TSC approval for lower scores). ## Release Notes ``` == NO RELEASE NOTE == ```
diff --git a/presto-oracle/src/main/java/com/facebook/presto/plugin/oracle/OracleClient.java b/presto-oracle/src/main/java/com/facebook/presto/plugin/oracle/OracleClient.java
@@ -162,7 +162,7 @@ public TableStatistics getTableStatistics(ConnectorSession session, JdbcTableHan
             requireNonNull(handle.getTableName(), "table name is null");
             String sql = format(
                     "SELECT NUM_ROWS, AVG_ROW_LEN, LAST_ANALYZED\n" +
-                            "FROM   DBA_TAB_STATISTICS\n" +
+                            "FROM   ALL_TAB_STATISTICS\n" +
                             "WHERE  OWNER='%s'\n" +
                             "AND    TABLE_NAME='%s'",
                     handle.getSchemaName().toUpperCase(), handle.getTableName().toUpperCase());
@@ -190,9 +190,12 @@ public TableStatistics getTableStatistics(ConnectorSession session, JdbcTableHan
                     double lowValue = toDouble(resultSetColumnStats.getString("LOW_VALUE"));
                     double highValue = toDouble(resultSetColumnStats.getString("HIGH_VALUE"));
                     ColumnStatistics.Builder columnStatisticsBuilder = ColumnStatistics.builder()
-                            .setDataSize(Estimate.estimateFromDouble(resultSet.getDouble("DATA_LENGTH")))
                             .setNullsFraction(Estimate.estimateFromDouble(nullsCount / numRows))
                             .setDistinctValuesCount(Estimate.estimateFromDouble(ndv));
+                    if (resultSetColumnStats.getString("DATA_TYPE").startsWith("VARCHAR") ||
+                            resultSetColumnStats.getString("DATA_TYPE").startsWith("CHAR")) {
+                        columnStatisticsBuilder.setDataSize(Estimate.estimateFromDouble(resultSetColumnStats.getDouble("DATA_LENGTH")));
+                    }
                     ColumnStatistics columnStatistics = columnStatisticsBuilder.build();
                     if (Double.isFinite(lowValue) && Double.isFinite(highValue)) {
                         columnStatistics = columnStatisticsBuilder.setRange(new DoubleRange(lowValue, highValue)).build();
