Add hdp3.1-hive, hdp3.1-hive-kerberized and centos7-oj8-openldap#57
Conversation
|
|
| FROM prestodb/centos7-oj8:unlabelled | ||
|
|
||
| # Change default timezone | ||
| RUN ln -snf "/usr/share/zoneinfo/Asia/Kathmandu" /etc/localtime && echo "Asia/Kathmandu" > /etc/timezone |
There was a problem hiding this comment.
This comes from its original file, I'll remove later
|
@wanglinsong Most of the files are copied from old version, I'll make it work first, then refactor the files. |
85f85d5 to
aaf2676
Compare
|
You still need the CLA Authorization. |
Fixed by adding the co-author |
imjalpreet
left a comment
There was a problem hiding this comment.
@unidevel We have one more image centos6-oj8-openldap which is used in Presto, should we upgrade it as well to centos7?
|
@imjalpreet I'll investigate. |
imjalpreet
left a comment
There was a problem hiding this comment.
@unidevel thanks for the PR, I successfully ran the Presto integration tests using the hive4.0-hive, hdp3.1-hive, and hdp3.1-hive-kerberized images. However, I encountered issues with the centos7-oj8-openldap image.
The Presto server fails to start when using that image, which suggests there may be a problem with the LDAP setup or a certificate issue.
For reference, here is a sample run with centos7-oj8-openldap image: https://github.com/prestodb/presto/actions/runs/15119301841/job/42498832069?pr=25143
|
Error message: |
|
@imjalpreet the openldap seems removed the anonymous bind after upgrade, I have to remove the bind_anon to make it work, but I think this may need to be addressed in the presto code. |
| #dn: cn=config | ||
| #changetype: modify | ||
| #add: olcDisallows | ||
| #olcDisallows: bind_anon |
There was a problem hiding this comment.
Removed olcDisallows: bind_anon
There was a problem hiding this comment.
Thank you for looking into it, I will test with this change. Just to get some more idea, is this something that wasn't configured in the old centos6 image?
There was a problem hiding this comment.
I triggered another run with the new image, the anonymous bind error is fixed, but there are a couple of other test failures related to keystore/truststore(https://github.com/prestodb/presto/actions/runs/15119301841/job/42634779349?pr=25143). I will investigate. Thank you for the temporary fix.
There was a problem hiding this comment.
@imjalpreet I noticed the default jdk is zulu jdk 11 in centos7-oj8, I updated it to jdk 1.8.0. Since the openldap updated the keystore only for jdk 1.8.0 that may cause the case failed, you need update both centos7-oj8 and centos7-oj8-openldap to test
make prestodb/centos7-oj8@local
make prestodb/centos7-oj8-openldap
There was a problem hiding this comment.
Actually it was just a change in the error message, the tests passed after a small fix
There was a problem hiding this comment.
There was a problem hiding this comment.
removed the last commit since it is not necessary.
There was a problem hiding this comment.
@unidevel I am also testing some Presto changes so that we can disable anonymous bind again. I will update you once I have verified my change.
Can you confirm if only these 4 lines need to be uncommented to disable anonymous bind or are there any other changes we will have to revert?
There was a problem hiding this comment.
The commit include other changes => unidevel@bceb4de, you need rebuild the image centos7-oj8-openldap, then build hive4.0-hive.
Since the hive4.0-hive is removed from this PR, you can checkout my new branch https://github.com/unidevel/docker-images/tree/hive4.0-hive, to build the images
imjalpreet
left a comment
There was a problem hiding this comment.
@unidevel, would you mind creating a separate PR for the hive4.0-hive image? We are ready to release the remaining images, but Hive needs a little bit more time.
|
Also, could we squash the commits into fewer commits, perhaps one per image, or in any way that you think makes the most sense? |
Sure, will update later |
|
squashed into one commit. |
|
Removed hive4.0-hive |
imjalpreet
left a comment
There was a problem hiding this comment.
I’ve verified the latest images in this PR: prestodb/presto#24799, and everything looks good.
Just had a quick question, should we consider moving the release.yml and .gitignore changes into a separate commit?
|
@tdcmeehan, could you please help merge this, too? thanks! |
This PR added the following images:
cherry-picked a commit from trino to get hdp3.1-hive files
https://github.com/trinodb/docker-images/tree/master/archived/hdp3.1-hive
Mac with M chips
Please setup the environment before building the images
hive4.0-hive
(Note: HADOOP_VERSION=3.4.1 & HIVE_VERSION=4.0.1)
To build the image
hdp3.1-hive
To build the image
hdp3.1-hive-kerberized
centos7-oj8-openldap