Merged
Conversation
#57) * fix callbacks * name * fix * callbacks * docstrings * fix * notebook
taylormjs
commented
Apr 2, 2025
src/lobster/data/_ume_datamodule.py
Outdated
| dataset_class=CalmIterableDataset, | ||
| modality=Modality.NUCLEOTIDE, | ||
| supported_splits={Split.TRAIN}, # TODO: add splits | ||
| supported_splits={"train_full", "train_iid", "val_iid", "heldout"}, |
Collaborator
Author
There was a problem hiding this comment.
Updated the available splits for calm. Didn't add enum for these, but can add if we want
Collaborator
There was a problem hiding this comment.
I wonder whether for training we should just keep it simple as train, test and have more robust evaluation outside of the datamodule?
taylormjs
commented
Apr 2, 2025
| Training data is originally from FASTA files containing coding DNA sequences. | ||
| """ | ||
|
|
||
| SUPPORTED_SPLITS: ClassVar[list[str]] = ["train_full", "train_iid", "val_iid", "heldout"] |
karinazad
reviewed
Apr 2, 2025
src/lobster/data/_calm_datamodule.py
Outdated
| Function or transform to apply to the data, by default None. | ||
| split_mode : str, optional | ||
| Split mode to use. Options: | ||
| - "pre_split": Use pre-created IID splits (train_iid, val_iid) and heldout for test |
Collaborator
There was a problem hiding this comment.
I think we could make this the only default option and not allow customized splits so it's more in line with the rest of the HF datasets?
karinazad
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.