Merged
Conversation
Collaborator
taylormjs
commented
Mar 24, 2025
- Iterable dataset for OpenGenome2 (8.84T tokens from genomic sequences)
- Added DatasetInfo to UME datamodule (WARNING: about 64 times larger than AMPLIFY ito token size)
taylormjs
commented
Mar 24, 2025
| modality=Modality.NUCLEOTIDE, | ||
| supported_splits={Split.TRAIN}, # TODO: add splits | ||
| train_size=8_780_000, | ||
| train_size=8_780_000, # NOTE - this is an underestimate (whole genomes much longer) |
Collaborator
Author
There was a problem hiding this comment.
Though if we are just truncating to the first 512-1024 tokens, then I suppose this is accurate, assuming all train_sizes estimated with num samples and not num tokens
Collaborator
|
looks good! should we implement a cap on the training size? could be in the HF iterator dataset |
ncfrey
approved these changes
Mar 25, 2025
Collaborator
Author
|
@karinazad A cap's a great idea. Would opengenome2 exceed the cap size? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.