Conversation
taylormjs
approved these changes
Sep 3, 2025
| num_hidden_layers: int = 28, | ||
| num_attention_heads: int = 12, | ||
| intermediate_size: int = 3072, | ||
| embedding_init_range: float = 0.02, |
Collaborator
There was a problem hiding this comment.
Yeah, UME-medium is probably the best model to compare with. Good defaults
| "labels": labels, | ||
| "attention_mask": attention_mask.to(torch.bool), | ||
| } | ||
| else: |
Collaborator
There was a problem hiding this comment.
Q - are the ModernBERT base checkpoints trained without packing? Just noting this so we have the fairest comparison
| def _init_weights(self, module): | ||
| if isinstance(module, nn.Linear): | ||
| module.weight.data.uniform_(-self.config.decoder_init_range, self.config.decoder_init_range) | ||
| elif isinstance(module, nn.Embedding): |
Collaborator
There was a problem hiding this comment.
Oh interesting that uniform initialization is used
Comment on lines
+15
to
+16
| class NeoBERTLightningModule(LightningModule): | ||
| def __init__( |
Collaborator
There was a problem hiding this comment.
Nice, good call having a separate LightningModule and nn.Module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds NeoBERT from https://huggingface.co/chandar-lab/NeoBERT/tree/main with few changes
Type of Change