Conversation
ncfrey
approved these changes
Jul 18, 2025
Contributor
ncfrey
left a comment
There was a problem hiding this comment.
do you need to be on GPU to run the test?
Collaborator
Author
Good point! Changed to CPU test without flash attention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make UME embeddings coming out of
UME.embedmatch the current dtype of the model. Currently, embeddings are being returned astorch.float32even when the model has been cast tobfloat16.Also includes a test for embedding output matching the expected dtype. Test fails without the change, test passes with the change.
Type of Change
Testing
Checklist