Merged
Conversation
karinazad
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to synthetic dataset generation, UME model training, and reward computation for RL training. Key changes include adding tagging for generated sequences, updating training configurations, refining reward logging, and enhancing reward computation to handle invalid completions.
Synthetic Dataset Enhancements:
examples/generate_synthetic_dataset.pyto include tags (<smiles>,<amino_acid>,<dna>) for better content identification. [1] [2] [3]Training Configuration Updates:
examples/train_ume_grpo.pytoume-medium-base-480Mfor training purposes, replacing the smaller debugging model.Reward Computation Improvements:
src/lobster/rl_training/reward_functions.pyto penalize invalid completions with a configurablepenalty_for_invalidparameter and added logic to extract tagged content for modality detection. This ensures only valid tagged sequences are rewarded. [1] [2] [3] [4]no_tag_count,empty_content_count) and adjusted logging to reflect these metrics.Logging Refinements:
src/lobster/callbacks/_ume_grpo_logging_callback.pyto log sample examples only when data is available and introduced step-specific tables for immediate logging during training. [1] [2]Documentation Updates:
src/lobster/rl_training/README.md, including guidelines for determining appropriate penalties based on reward distributions.