Merged
Conversation
karinazad
reviewed
Jun 12, 2025
| ) | ||
| attn = attn.transpose(1, 2).view(unpad_bs, -1, dim) # b s h d | ||
| attn = unpad_input_only(attn, torch.squeeze(attn_mask) == 1) | ||
| # Use native unpadded SDPA without padding/unpadding |
Collaborator
There was a problem hiding this comment.
is this duplicated with lines above (160-180)?
Contributor
Author
There was a problem hiding this comment.
yeah we need to do unpadded SDPA in FlexBertUnpadAttention and BertAlibiUnpadSelfAttention
karinazad
reviewed
Jun 12, 2025
tests/lobster/model/test__ume.py
Outdated
| except (ImportError, NoCredentialsError, ClientError) as e: | ||
| pytest.skip(f"S3 bucket 'prescient-lobster' not accessible: {e}") | ||
|
|
||
| checkpoint_path = "s3://prescient-lobster/ume/runs/2025-06-11T02-12-16/epoch=0-step=19500-val_loss=1.0225.ckpt" |
Collaborator
There was a problem hiding this comment.
this might fail in the future if we change the architecture
Collaborator
There was a problem hiding this comment.
how long does this take? when I load checkpoints locally, it's usually +10 mins
Collaborator
There was a problem hiding this comment.
maybe we can remove this test? up to you
Contributor
Author
There was a problem hiding this comment.
good call, i'll remove it and keep the test script. it's really slow and brittle
karinazad
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.