Skip to content

Standardizing Transform import to lobster.transforms for consistency? #157

@young-su-ko

Description

@young-su-ko

Hi! I was reading through and familiarizing myself with the codebase.

I noticed that in most files under /datasets, we import Transform like this:
from lobster.transforms import Transform

but in a few cases, the import comes from beignet instead:
from beignet.transforms import Transform

Specifically:


Comparing the two Transform classes in lobster and beignet,
The only implementation difference I found is that the Beignet version explicitly calls zip(..., strict=False), while the Lobster version just calls zip(...) which should default to strict=False.

Proposal:
Would it make sense to standardize the imports by switching these few cases to use lobster.transforms.Transform for consistency?


I’m new to contributing to open source and thought this might be a safe PR to get familiar with the contribution workflow. If this change is welcome, I’d love to submit a PR!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions