fix: editability check during pypi install#5617
Merged
baszalmstra merged 1 commit intoprefix-dev:mainfrom Mar 6, 2026
Merged
Conversation
f0fc428 to
543de42
Compare
baszalmstra
approved these changes
Mar 6, 2026
tdejager
commented
Mar 6, 2026
| ) -> bool { | ||
| manifest_pypi_deps | ||
| .get(package_name) | ||
| .and_then(|specs| specs.iter().find_map(|spec| spec.editable())) |
Contributor
Author
There was a problem hiding this comment.
Note that spec.editable is an optional, so we are finding the first set value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5604
This happened because the spec is duplicated and so both the registry
requestsand the localrequestsgot passed into the solver. uv prefers the local one, so all good. However, we selected the registry requests version when determining editability. Now we just select by looking at all duplicates, as you cannot set editability directly in pep508 it should be good.In the case of pixi features:
The
falseshould be taken as it has higher precedenceHow Has This Been Tested?
Manually by using:
clone requests from github.
Use:
pixi install<-- Built version of pixi/tmp/5604 is 📦 v0.1.0 via 🐍 took 57s ❯ ls .pixi/envs/default/lib/python3.14/site-packages/ | grep .pth __editable__.requests-2.33.0.dev1.pth❯ ls .pixi/envs/prod/lib/python3.14/site-packages/ | grep .pth conda-site.pthAI Disclosure
Tools: Opus 4.6
Checklist: