fix: add compiler(c) per default with pixi-build-rust#5457
Merged
Hofer-Julian merged 1 commit intoprefix-dev:mainfrom Feb 10, 2026
Merged
fix: add compiler(c) per default with pixi-build-rust#5457Hofer-Julian merged 1 commit intoprefix-dev:mainfrom
compiler(c) per default with pixi-build-rust#5457Hofer-Julian merged 1 commit intoprefix-dev:mainfrom
Conversation
compiler(c) per default with pixi-build-rust
22b3090 to
9e1a769
Compare
baszalmstra
approved these changes
Feb 10, 2026
ruben-arts
reviewed
Feb 10, 2026
crates/pixi-build-rust/src/main.rs
Outdated
Comment on lines
83
to
84
| // Get the list of compilers from config, defaulting to ["rust", "c"] if not | ||
| // specified |
Contributor
There was a problem hiding this comment.
Your explainer in the PR description was very helpful as I was confused by this. What do you think about this line?
Suggested change
| // Get the list of compilers from config, defaulting to ["rust", "c"] if not | |
| // specified | |
| // Get the list of compilers from config, defaulting to ["rust", "c"] if not | |
| // specified. The rust compilers already depend on the compiler. | |
| // Adding it here helps with versioning it throug the variants. |
9e1a769 to
d2435a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All Rust compilers depend on a C compiler on conda-forge. For example,
rust_linux_64depends ongcc_linux-64without version bounds.If that is already the case it makes sense to just add the c compiler per default. That way, you can the c_compiler_version variant will actually affect the version of the used C compiler
How Has This Been Tested?
pixi run test-fastChecklist: