fix: comparison of None in git source subdir vs empty string#5269
fix: comparison of None in git source subdir vs empty string#5269baszalmstra merged 12 commits intoprefix-dev:mainfrom
Conversation
| match self { | ||
| PinnedSourceSpec::Path(spec) => write!(f, "{}", spec.path), | ||
| PinnedSourceSpec::Url(spec) => write!(f, "{}", spec.url), | ||
| PinnedSourceSpec::Git(spec) => write!(f, "{}@{}", spec.git, spec.source.commit), |
There was a problem hiding this comment.
this just usese the formatter from Git Source instead.
|
Im thinking to further avoid this issue, we could also type this correctly. Maybe we can just represent the root subdirectory as "" too? Or if we do want to makenthe distinction between not specified and empty we could add a new type? |
|
There are a few (serialization) failures now because e.g. @baszalmstra do you know the impact of this? I don't think there will be a lot of |
|
@wolfv If you can get it to work with a |
Description
This should fix #5226 - the git source had a empty string as subdirectory while the other one had
Noneand thus they compared as not equal.How Has This Been Tested?
I tested this with the numpy reproducer.
AI Disclosure
All code was written by Mr. Claude
Checklist:
schema/model.py.