fix: fix freeze and update examples#5255
Merged
baszalmstra merged 5 commits intoprefix-dev:mainfrom Jan 9, 2026
Merged
Conversation
baszalmstra
commented
Jan 9, 2026
| for tx in pending.drain(..) { | ||
| match tx.send(Err(err)) { | ||
| Ok(_) => return, | ||
| Ok(_) => break, |
Contributor
Author
There was a problem hiding this comment.
This was causing the freeze. Because previously we immediately returned we didnt actually drain the entire array. With break we break out of the loop, after the look the pending array is reset which then cancels the rest.
hunger
approved these changes
Jan 9, 2026
| for tx in pending.drain(..) { | ||
| match tx.send(Err(err)) { | ||
| Ok(_) => return, | ||
| Ok(_) => break, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a nasty sporadic freeze, and updates some of the examples to use our nightly (pixi-build-backends) channel.
How Has This Been Tested?
All tests in CI are fixing.
Checklist:
schema/model.py.