feat: fix installation reading editable from the lock incorrectly#5249
Merged
ruben-arts merged 7 commits intoprefix-dev:mainfrom Jan 13, 2026
Merged
Conversation
ruben-arts
approved these changes
Jan 8, 2026
Contributor
ruben-arts
left a comment
There was a problem hiding this comment.
Thanks, this is indeed better 👍
nichmor
requested changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where if you had a PyPI dependency like:
And the lock still contained an
editable: truethat it would incorrectly install the package as editable. This is broken, and there is a test in this PR that simulates that situation. Not sure we want to keep it because we would need to remove it with a lock file break.I also tested this on my machine locally, by simulating the same situation.
How Has This Been Tested?
With test and by myself.
AI Disclosure
Tools: Claude and me for the test
Checklist: