Skip to content

feat: fix installation reading editable from the lock incorrectly#5249

Merged
ruben-arts merged 7 commits intoprefix-dev:mainfrom
tdejager:feat/fix-install-editable-incorrect
Jan 13, 2026
Merged

feat: fix installation reading editable from the lock incorrectly#5249
ruben-arts merged 7 commits intoprefix-dev:mainfrom
tdejager:feat/fix-install-editable-incorrect

Conversation

@tdejager
Copy link
Contributor

@tdejager tdejager commented Jan 8, 2026

Description

This fixes an issue where if you had a PyPI dependency like:

[tool.pixi.pypi-dependencies]
bingo = { path = "." }

And the lock still contained an editable: true that it would incorrectly install the package as editable. This is broken, and there is a test in this PR that simulates that situation. Not sure we want to keep it because we would need to remove it with a lock file break.

I also tested this on my machine locally, by simulating the same situation.

How Has This Been Tested?

With test and by myself.

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: Claude and me for the test

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added sufficient tests to cover my changes.

@tdejager tdejager requested review from nichmor and ruben-arts January 8, 2026 15:52
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is indeed better 👍

@ruben-arts ruben-arts enabled auto-merge (squash) January 8, 2026 15:56
Copy link
Contributor

@nichmor nichmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@ruben-arts ruben-arts merged commit 69b68c3 into prefix-dev:main Jan 13, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants