fix: reporter context retrieval#5202
Merged
ruben-arts merged 7 commits intoprefix-dev:mainfrom Dec 29, 2025
Merged
Conversation
baszalmstra
requested changes
Dec 24, 2025
Contributor
baszalmstra
left a comment
There was a problem hiding this comment.
Yes this doesnt seem right. Instead we should just cancel the child task as well because most likely the parent errored or was itself cancelled.
Contributor
I've added a child cancellation token ( from parent token ). |
nichmor
approved these changes
Dec 29, 2025
4 tasks
2 tasks
Contributor
|
@nichmor When you have time can you point me to how this now fixes the issue. I dont understand why this would fix the issue. From my perspective the tasks were already cancelled anyway? The child cancellation tokens are also never cancelled manually are they? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Assuming this might fix #5200
How Has This Been Tested?
I've been testing this with the https://github.com/ruben-arts/ros_workspace as that spawns multiple backends, and it was the only project I could get the error with. I've not been able to recreate the race condition, but they are tricky so this is not a promised fix.
I've extended the stress test by making it multi-env, with pypi sdist and solving for multiple platforms:
I can't seem to break it anymore, but it was hard in the first place, so 🤞
AI Disclosure
Tools: Claude
Checklist:
This type of issue is almost impossible to recreate in a test as it's flaky behavior.