fix: use global config tls setting with self-update#5119
Merged
baszalmstra merged 1 commit intomainfrom Dec 12, 2025
Merged
Conversation
The `latest_version()` function was calling `reqwest_client_builder(None)` which doesn't load global configuration and defaults to using webpki bundled certificates. This caused the version check to fail with TLS errors for users who have configured `tls-root-certs = "native"` for corporate firewall compatibility. The fix loads the global config using `Config::load_global()` and passes it to `reqwest_client_builder()`, consistent with how `build_reqwest_clients()` handles the None case. Fixes #5117
self-updateself-update
self-updateself-update
wolfv
approved these changes
Dec 12, 2025
baszalmstra
approved these changes
Dec 12, 2025
Contributor
Author
|
@baszalmstra should we merge it to main and have OP test from there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
latest_version()function was callingreqwest_client_builder(None)which doesn't load global configuration and defaults to using webpki bundled certificates. This caused the version check to fail with TLS errors for users who have configuredtls-root-certs = "native"for corporate firewall compatibility.The fix loads the global config using
Config::load_global()and passes it toreqwest_client_builder(), consistent with howbuild_reqwest_clients()handles the None case.Description
Fixes #5117
How Has This Been Tested?
Not sure how to test this I would hope the OP of the issue couid give it a try.
AI Disclosure
Tools: Opus 4.5
Checklist:
schema/model.py.