fix: change binary to source should always select source#5098
Merged
ruben-arts merged 1 commit intoprefix-dev:mainfrom Dec 10, 2025
Merged
fix: change binary to source should always select source#5098ruben-arts merged 1 commit intoprefix-dev:mainfrom
ruben-arts merged 1 commit intoprefix-dev:mainfrom
Conversation
baszalmstra
commented
Dec 9, 2025
| manifest_source = ?self.manifest_source, | ||
| build_source = ?self.preferred_build_source, | ||
| manifest_source = %self.manifest_source, | ||
| build_source = self.preferred_build_source.as_ref().map(tracing::field::display), |
Contributor
Author
There was a problem hiding this comment.
Fixes an issue where the log output was veeery verbose.
2 tasks
ruben-arts
approved these changes
Dec 10, 2025
Contributor
ruben-arts
left a comment
There was a problem hiding this comment.
Amazing! This fixed my issue! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where if a lock-file contained a binary package it would always be selected for transitive dependencies even if a source package was available. This PR changes this behavior to ensure that only source packages are used if they are specified.
Fixes #5065
How Has This Been Tested?
I tested this manually on the reproducer in the issue.
Checklist:
schema/model.py.