feat: Add `feature` CLI commands and add remove_feature to pixi_api by haecker-felix · Pull Request #5086 · prefix-dev/pixi

haecker-felix · 2025-12-09T08:09:18Z

Description

Adds a new remove_feature to pixi_api WorkspaceContext, which removes a feature from a manifest (and also removes it from environments as well, if necessary).

Also adds new pixi workspace feature rm/ls CLI commands.

pixi % pixi workspace feature rm build
Feature 'build' gets used by the following environment(s): default, lint, test-native-certs. Do you want to remove it anyway? yes
✔ Removed feature build

pixi % pixi workspace feature ls
Features:
- default:
    dependencies: cargo-insta, git, python
    tasks: insta, test-all-extra-slow, install-as, generate-cli-docs, test, install, test-fast, test-all-fast, install-debug-as, build-debug, pypi-proxy, build-release, test-slow, run-all-examples, test-all-slow, release, bump
- pytest:
    dependencies: dirty-equals, filelock, inline-snapshot, py-rattler, pytest, pytest-rerunfailures, pytest-timeout, pytest-xdist, pyyaml, rattler-build, rich, tomli-w, types-pyyaml
    tasks: test-specific-test, test-integration-ci, test-integration-extra-slow-ci, test-specific-test-debug, test-integration-slow, test-integration-extra-slow, update-test-channel, test-common-wheels, test-integration-fast, test-common-wheels-ci
- dev:
    dependencies: cargo-edit, cargo-nextest, cffconvert, tbump
    tasks: switch-to-remote-rattler, switch-to-local-uv, snapshot-update, switch-to-local-rattler, insta-review, update-rattler, switch-to-remote-uv
- lint:
    dependencies: actionlint, basedpyright, cargo-deny, cargo-shear, dprint, go-shfmt, lefthook, ruff, shellcheck, taplo, typos
    tasks: toml-lint, pre-commit-install, typecheck-python, cargo-fmt, shell-format, dprint-fmt, ruff-format, lint-fast, lefthook, dprint-check, pre-commit-install-minimal, cargo-clippy, cargo-deny, typos, cargo-shear, lint-slow, lint, ruff-lint, check-openssl, actionlint, toml-format
- rust:
    dependencies: rust
- build:
    dependencies: compilers, git, openssl, pkg-config, rust-src
- docs:
    dependencies: cairosvg, git-cliff, mdx_truly_sane_lists, mike, mkdocs-llmstxt, mkdocs-material, mkdocs-redirects, pillow
    tasks: mike-serve, deploy-latest, docs, deploy-dev, bump-changelog, build-docs
- schema:
    dependencies: jsonschema, pydantic, pyyaml
    tasks: test-schema, generate-schema
- pypi-gen:
    dependencies: hatchling, python-build
    tasks: pypi-gen-indexes
- micromamba:
    dependencies: micromamba
    tasks: test-export
- trampoline:
    dependencies: python, zstd
    tasks: build-trampoline
- recipes:
    dependencies: rattler-build
    tasks: build-backends
- dist:
    dependencies: zig
- native-certs-test:
    dependencies: mkcert, pip, rich, testcontainers
    tasks: test-native-certs

Closes #1999

The issue also mentions a feature add command, which doesn't make much sense, since it would add an empty TOML table and features are getting added / edited implicitly via other commands, like pixi add / remove --feature foo

AI Disclosure

This PR contains AI-generated content.
- I have tested any AI-generated content in my PR.
- I take responsibility for any AI-generated content in my PR.
  Tools: Claude code

Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added sufficient tests to cover my changes.

crates/pixi_cli/src/workspace/feature.rs

Hofer-Julian

Looks good overall. I had a few comments and questions :)

crates/pixi_api/src/workspace/workspace/feature.rs

crates/pixi_manifest/src/manifests/workspace.rs

Hofer-Julian · 2025-12-10T08:55:09Z

crates/pixi_cli/src/workspace/feature.rs

+            writeln!(
+                std::io::stdout(),


Why did you not use println! here?

I'm not entirely sure, I just used environment here as reference, so it's consistent between different commands.

https://github.com/prefix-dev/pixi/blob/main/crates/pixi_cli/src/workspace/environment.rs#L77

Maybe you can check who introduced that and ask them. I am curious now. But no blocker for merging it then :)

It has to do with broken pipes without it.

Hofer-Julian · 2025-12-10T08:55:49Z

crates/pixi_cli/src/workspace/feature.rs

+            .inspect_err(|e| {
+                if e.kind() == std::io::ErrorKind::BrokenPipe {
+                    std::process::exit(0);
+                }
+            })


Why is this necessary?

I'm not entirely sure, I just used environment here as reference, so it's consistent between different commands.

https://github.com/prefix-dev/pixi/blob/main/crates/pixi_cli/src/workspace/environment.rs#L95

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

ruben-arts

Great work, not big changes required. Would love to see my nitpick but I'm not keeping it from being merged because of that so I'm approving it!

ruben-arts · 2025-12-10T09:23:32Z

crates/pixi_cli/src/workspace/feature.rs

+                    let mut details = Vec::new();
+
+                    if !deps.is_empty() {
+                        details.push(format!("    dependencies: {}", deps.join(", ")));


Very nitpicky but I always like colors to read more quickly, we use green for conda deps and blue for pypi deps. Would you want to add that?

your wish shall be granted ✅ a4615b8

feat: Add remove_feature to pixi_api

72d6a49

haecker-felix marked this pull request as draft December 9, 2025 08:09

haecker-felix added the Rust API label Dec 9, 2025

haecker-felix added 6 commits December 9, 2025 09:41

Work with FeatureName instead of str

b10a01a

Confirm before removing a feature, if it gets used in environmnets

b16478c

feat: Expose remove_feature to pixi cli as well

f931c1c

Implement "pixi workspace feature ls" as well

9cc50a1

Update CLI docs

e0f25dc

refactor

7495463

haecker-felix marked this pull request as ready for review December 9, 2025 12:58

Hofer-Julian requested review from Hofer-Julian and ruben-arts December 9, 2025 12:59

Hofer-Julian reviewed Dec 9, 2025

View reviewed changes

crates/pixi_cli/src/workspace/feature.rs Show resolved Hide resolved

haecker-felix changed the title ~~feat: Add remove_feature to pixi_api~~ feat: Add feature CLI commands and add remove_feature to pixi_api Dec 9, 2025

haecker-felix mentioned this pull request Dec 9, 2025

Unified Pixi API tracking issue #4638

Open

94 tasks

Hofer-Julian reviewed Dec 10, 2025

View reviewed changes

haecker-felix and others added 3 commits December 10, 2025 10:01

Update crates/pixi_api/src/workspace/workspace/feature.rs

c1133cd

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

Update crates/pixi_manifest/src/manifests/workspace.rs

c4a474c

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

Update crates/pixi_manifest/src/manifests/workspace.rs

ca7b345

Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>

ruben-arts approved these changes Dec 10, 2025

View reviewed changes

Color dependencies

a4615b8

ruben-arts enabled auto-merge (squash) December 10, 2025 09:47

ruben-arts merged commit 941fdb2 into prefix-dev:main Dec 10, 2025
74 of 75 checks passed

BrewTestBot mentioned this pull request Dec 17, 2025

pixi 0.62.0 Homebrew/homebrew-core#259009

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add `feature` CLI commands and add remove_feature to pixi_api#5086

feat: Add `feature` CLI commands and add remove_feature to pixi_api#5086
ruben-arts merged 11 commits intoprefix-dev:mainfrom
haecker-felix:pixi_api_features

haecker-felix commented Dec 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Hofer-Julian left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hofer-Julian Dec 10, 2025

Uh oh!

haecker-felix Dec 10, 2025

Uh oh!

Hofer-Julian Dec 10, 2025

Uh oh!

ruben-arts Dec 10, 2025

Uh oh!

Hofer-Julian Dec 10, 2025

Uh oh!

haecker-felix Dec 10, 2025

Uh oh!

ruben-arts left a comment

Uh oh!

ruben-arts Dec 10, 2025

Uh oh!

haecker-felix Dec 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

haecker-felix commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

AI Disclosure

Checklist:

Uh oh!

Uh oh!

Hofer-Julian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ruben-arts left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

haecker-felix commented Dec 9, 2025 •

edited

Loading