Skip to content

fix: exclude reserved names from task arg names in schema#5078

Merged
baszalmstra merged 2 commits intoprefix-dev:mainfrom
bollwyvl:gh-4949-exclude-pixi-from-task-arg-name
Dec 9, 2025
Merged

fix: exclude reserved names from task arg names in schema#5078
baszalmstra merged 2 commits intoprefix-dev:mainfrom
bollwyvl:gh-4949-exclude-pixi-from-task-arg-name

Conversation

@bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Dec 8, 2025

Description

This excludes pixi from valid task arg names, hopefully in a way which can be extended later.

Continues #4949

How Has This Been Tested?

Adds a new, otherwise-valid invalid/reserved_arg_name.toml

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

@bollwyvl bollwyvl force-pushed the gh-4949-exclude-pixi-from-task-arg-name branch from 6ccfcc7 to 4a9c954 Compare December 8, 2025 16:14
@bollwyvl bollwyvl changed the title exclude reserved names from task arg names fix: exclude reserved names from task arg names in schema Dec 8, 2025
@bollwyvl bollwyvl marked this pull request as ready for review December 8, 2025 16:25
@bollwyvl bollwyvl mentioned this pull request Dec 8, 2025
Merged
8 tasks
baszalmstra
baszalmstra approved these changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@baszalmstra baszalmstra merged commit 4fab350 into prefix-dev:main Dec 9, 2025
38 checks passed
@bollwyvl bollwyvl deleted the gh-4949-exclude-pixi-from-task-arg-name branch December 9, 2025 14:24
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Dec 9, 2025

Thanks for the review.

I still crave for either:

  • a static schema to be generated from the underlying .rs
  • a pixi check or equivalent CLI subcommand to e.g. use as an oracle during property-based testing with hypothesis-jsonschema:
    • what is the minimum manifest that conforms to the schema but won't load in pixi? The reverse?

@BrewTestBot BrewTestBot mentioned this pull request Dec 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baszalmstra baszalmstra baszalmstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bollwyvl @baszalmstra