fix: use single quotes for CLI arg joining to fix backslash escaping#5063
Merged
baszalmstra merged 1 commit intoprefix-dev:mainfrom Dec 5, 2025
Conversation
tdejager
approved these changes
Dec 4, 2025
…refix-dev#5054) This fixes the double-escaping of backslashes in `pixi run` command arguments. The issue was a mismatch between shlex::try_join's POSIX double-quote escaping and deno_task_shell's parsing. deno_task_shell doesn't unescape `\\` to `\` inside double quotes the way POSIX shells do. The fix uses single quotes where possible (which preserve backslashes literally), and falls back to double quotes for strings containing single quotes. Before: pixi run echo 'test\ntest' → test\\ntest (doubled backslash) After: pixi run echo 'test\ntest' → test\ntest (correct) Fixes prefix-dev#5054
2fda87f to
f8d0333
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes the double-escaping of backslashes in
pixi runcommand arguments.The issue was a mismatch between
shlex::try_join's POSIX double-quote escaping anddeno_task_shell's parsing.deno_task_shelldoesn't unescape\\to\inside double quotes the way POSIX shells do.The fix uses single quotes where possible (which preserve backslashes literally), and falls back to double quotes for strings containing single quotes.
Before:
pixi run echo 'test\ntest'→test\\ntest(doubled backslash)After:
pixi run echo 'test\ntest'→test\ntest(correct)Fixes #5054
Fixes #4579
How Has This Been Tested?
In CI and manually:
Old:
New:
AI Disclosure
Tools: Claude Code Opus 4.5
Checklist:
schema/model.py.