Skip to content

fix: index was being ignored during upgrades#5062

Merged
baszalmstra merged 4 commits intoprefix-dev:mainfrom
tdejager:feature/pix-1185-pixi-upgrade-do-not-follow-pypi-dependencies-index
Dec 4, 2025
Merged

fix: index was being ignored during upgrades#5062
baszalmstra merged 4 commits intoprefix-dev:mainfrom
tdejager:feature/pix-1185-pixi-upgrade-do-not-follow-pypi-dependencies-index

Conversation

@tdejager
Copy link
Contributor

@tdejager tdejager commented Dec 4, 2025

Description

Fixes #4659

The problem is that the index was not retained when doing an upgrade, so that meant it was using the wrong index to do the dependency upgrade. I also though a TryFrom from a tuple that does merging is really unclear, so I made this into a function on the struct itself. Now we correctly take the index into account when updating.

How Has This Been Tested?

I've not tested it manually but I feel the automated test is essentially the user-test in this case. I tested that it fails without this change and succeeds with this change.

AI Disclosure

  • This PR contains AI-generated content.
    • [] I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: {e.g., Claude, Codex, GitHub Copilot, ChatGPT, etc.}

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

@tdejager tdejager requested a review from baszalmstra December 4, 2025 13:15
@tdejager tdejager added the test:extra_slow Run the extra slow tests label Dec 4, 2025
Co-authored-by: Tim de Jager <tdejager89@gmail.com>
@baszalmstra baszalmstra enabled auto-merge (squash) December 4, 2025 13:36
@baszalmstra baszalmstra merged commit 76267ee into prefix-dev:main Dec 4, 2025
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:extra_slow Run the extra slow tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pixi upgrade do not follow pypi dependencies index

2 participants