Skip to content

test: Mark more tests as online_tests#5060

Merged
baszalmstra merged 2 commits intoprefix-dev:mainfrom
mgorny:more-online
Dec 4, 2025
Merged

test: Mark more tests as online_tests#5060
baszalmstra merged 2 commits intoprefix-dev:mainfrom
mgorny:more-online

Conversation

@mgorny
Copy link
Contributor

@mgorny mgorny commented Dec 4, 2025

Description

Mark more tests as needing Internet.

How Has This Been Tested?

Applied the patch to the Gentoo ebuild where pixi is tested offline.

AI Disclosure

  • This PR contains AI-generated content.
    • I have tested any AI-generated content in my PR.
    • I take responsibility for any AI-generated content in my PR.

Tools: {e.g., Claude, Codex, GitHub Copilot, ChatGPT, etc.}

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added sufficient tests to cover my changes.
  • I have verified that changes that would impact the JSON schema have been made in schema/model.py.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny mgorny changed the title Mark more tests as online_tests test: Mark more tests as online_tests Dec 4, 2025
@mgorny mgorny marked this pull request as ready for review December 4, 2025 04:36
@baszalmstra
Copy link
Contributor

Thanks for flagging these! I think we can remove internet access from these tests as well. Let me give that a try.

@baszalmstra baszalmstra enabled auto-merge (squash) December 4, 2025 10:13
Copy link
Contributor

@baszalmstra baszalmstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some changes to your PR to remove the offline flags and actually make the tests work offline. If you still have issues with this, feel free to ping me here!

@baszalmstra baszalmstra merged commit d76ee82 into prefix-dev:main Dec 4, 2025
38 checks passed
@mgorny mgorny deleted the more-online branch December 4, 2025 11:20
@mgorny
Copy link
Contributor Author

mgorny commented Dec 4, 2025

Thanks, that's even better. I'll retest around the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants