feat: new rattler-upload functionality#5017
Merged
tdejager merged 6 commits intoprefix-dev:mainfrom Dec 4, 2025
Merged
Conversation
wolfv
reviewed
Dec 3, 2025
Member
wolfv
left a comment
There was a problem hiding this comment.
Looks good except the little note about using the proper pixi configuration.
crates/pixi_cli/src/upload.rs
Outdated
| #[source] | ||
| source: reqwest::Error, | ||
| }, | ||
| // Get authentication storage from pixi's auth system |
Member
There was a problem hiding this comment.
Is this the right way to do it in pixi? I am wondering if we have a better way through the configuration system and whether we can just load the default config (I think it might point to an auth file): https://pixi.sh/latest/reference/pixi_configuration/#authentication-override-file
Member
|
Looks good! I was kinda thinking we had a function on the Config object that would be something like |
wolfv
approved these changes
Dec 4, 2025
This was referenced Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small shim over the
rattler_uploadfunctionality, this is mostly and update to the documentation. Note, that this is a breaking change.How Has This Been Tested?
Because its just such a small shim, I hoped the corresponding rattler code has been well tested.
AI Disclosure
Tools: Claude Opus 4.5
Checklist:
schema/model.py.