feat: dont remove non pixi pypi installs#1043
Merged
tdejager merged 15 commits intoprefix-dev:mainfrom May 7, 2024
Merged
Conversation
nichmor
reviewed
Mar 22, 2024
nichmor
approved these changes
Mar 22, 2024
wolfv
approved these changes
Mar 22, 2024
auto-merge was automatically disabled
March 22, 2024 15:48
Pull request was converted to draft
Contributor
Author
|
Before merging we need to re-think the logic a bit.
|
Member
|
Two points:
|
Contributor
Author
|
Not yet, we should revive this. Although you can now use git dependencies if you want 😀 |
by us Also, added some logging when this happens because this might be unexpected.
ruben-arts
reviewed
Apr 30, 2024
ruben-arts
approved these changes
May 7, 2024
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the INSTALLER when removing packages either through changing of dependencies or python version.
Fixes: #998
We now have the following behavior:
uv-pixiand not managed by pixi we do not touch the package.uv-pixibut is managed by pixi we re-install.Also, In the case where we switch python interpreters, which requires a new
site-packagesfolder:The problem is that for existing installs these have the wrong installer, which is all installs done with an older pixi version: when this PR is merged the installer will automatically be updated and the following warning is shown once:
E.g for an environment with python and flask from pypi:
Because we are essentially re-installing all pypi-packages in the environment.
This is a bit ugly, but I've noticed people being suprised that if they tinker in an environment a re-install occurs.