Removed static from callables because it's deprecated since PHP 8.2#1642
Removed static from callables because it's deprecated since PHP 8.2#1642vladvildanov merged 1 commit intopredis:mainfrom
Conversation
|
This PR seems to be based on a misunderstanding - the code changes are all examples of static anonymous functions, not the static callables which have been deprecated. For reference, here is the deprecation notice, and here is the documentation of static anonymous functions - note that they're not deprecated as of the current version. |
Yes. This PR just out of the blue removed a small optimization for no real benefit. Marking closures static certainly isn't deprecated. Most of the time it's a micro-optimization, but sometimes it really help in preventing cycles. |
|
@talkinnl Wanna open a PR to add them back in? |
No description provided.