-
-
Notifications
You must be signed in to change notification settings - Fork 993
[2.x] ZPOPMIN & ZPOPMAX prefixes #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sngrl Would you mind to add a test coverage? Literally, it's just about extending already existing data provider in unit tests |
|
@vladvildanov tests already are presented, my PR just makes this commands to use prefixes \Predis\Command\Redis\ZPOPMIN_Test
\Predis\Command\Redis\ZPOPMAX_Test |
|
@sngrl2 Ah, my bad! Approved But you also need to run |
|
@tillkruss Ready to merge |
|
@vladvildanov Did you undo the commit? 🫠 |
|
@tillkruss I didn't, this branch was outdated and when I sync it it turns that this changes was done as a part of another commit, so tests are the only thing that were missing |
No description provided.