This repository was archived by the owner on Feb 7, 2026. It is now read-only.
Add option for custom libc#116
Merged
ralphtheninja merged 8 commits intoprebuild:masterfrom May 3, 2016
corbinu:feature/clib
Merged
Add option for custom libc#116ralphtheninja merged 8 commits intoprebuild:masterfrom corbinu:feature/clib
ralphtheninja merged 8 commits intoprebuild:masterfrom
corbinu:feature/clib
Conversation
Member
|
Sweet! @mafintosh new minor, right? |
Member
|
4.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to fix #108
It adds an option for libc argument and LIBC environment variable for use in systems like Alpine linux that use a custom libc.
I was unable to run the test suite on my Mac as it seems it is not currently working for node 6.0 but I am happy to add some tests as advised.
I have tested it using a scoped package which can be downloaded from NPM as @corbinu/prebuild.
I also released a version using it and the generated artifacts and travis script can be seen here: https://github.com/corbinu/couchnode