Skip to content

Conversation

@marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Mar 6, 2023

I can't exactly reconstruct why I accidentally uploaded a debug build for chrome yesterday when cutting a new version (see #467 ). My assumption is that I ran the run:chrome command which builds a debug extension and loads it into a fresh chrome instance. I typically always use that just before publishing to make a final smoke test check. Normally, I run the build:chrome command once that's done but it looks like I forgot that yesterday. That's very likely what happened yesterday.

To prevent such accidents in the future this PR makes a couple of changes:

  • Always use separate directories for debug and non-debug builds
  • Always add -debug suffix to zipped debug extensions
  • Use a global variable that must be injected to toggle debug mode instead of relying on process.env.DEBUG

@marvinhagemeister marvinhagemeister marked this pull request as ready for review March 6, 2023 14:54
@marvinhagemeister marvinhagemeister merged commit 5b0f130 into main Mar 6, 2023
@marvinhagemeister marvinhagemeister deleted the debug-no-env branch March 6, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants