Fixes bug in grid-areas. #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't really understand why the build is doing name mangling of classes and grid areas, but it appears there is already some code to deal with it. Unfortunately, that code doesn't work as *sometimes* the name mangler is including a leading `_` and sometimes it is not. Luckily, the fix is easy, just include support for an optional leading `_` in the existing regexp.
marvinhagemeister
approved these changes
Feb 28, 2023
Member
marvinhagemeister
left a comment
There was a problem hiding this comment.
Whoops good catch! Thanks for the PR 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't really understand why the build is doing name mangling of classes and grid areas, but it appears there is already some code to deal with it. Unfortunately, that code doesn't work as sometimes the name mangler is including a leading
_and sometimes it is not. Luckily, the fix is easy, just include support for an optional leading_in the existing regexp.