Skip to content

Force strict equality on vnode constructor #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 2 commits into from
Jan 9, 2026
Merged

Force strict equality on vnode constructor #4986

JoviDeCroock merged 2 commits into from
Jan 9, 2026
+6 −4

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jan 6, 2026 •
edited
Loading

Partially reverts #4723

@github-actions
Copy link

github-actions bot commented Jan 6, 2026 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-7.36ms - +9.79ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -0% - +0% (-0.03ms - +0.05ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -2% - +1% (-0.98ms - +0.76ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -5% - +1% (-0.81ms - +0.11ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.60ms - +0.72ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -3% - +9% (-0.06ms - +0.18ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.36ms - +0.52ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -4% - +4% (-1.16ms - +1.07ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.04ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.01ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -8% - +2% (-0.60ms - +0.15ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +4% (-0.01ms - +0.05ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -3% - +0% (-0.04ms - +0.00ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local907.19ms - 921.37ms-unsure 🔍
-1% - +1%
-7.36ms - +9.79ms
preact-main908.24ms - 917.89msunsure 🔍
-1% - +1%
-9.79ms - +7.36ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.04ms - 19.06ms-unsure 🔍
-0% - +0%
-0.04ms - +0.00ms
preact-main19.05ms - 19.08msunsure 🔍
-0% - +0%
-0.00ms - +0.04ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.54ms - 16.59ms-unsure 🔍
-0% - +0%
-0.03ms - +0.05ms
preact-main16.53ms - 16.58msunsure 🔍
-0% - +0%
-0.05ms - +0.03ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.54ms - 1.56ms-unsure 🔍
-1% - +1%
-0.01ms - +0.02ms
preact-main1.54ms - 1.56msunsure 🔍
-1% - +1%
-0.02ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local60.54ms - 61.79ms-unsure 🔍
-2% - +1%
-0.98ms - +0.76ms
preact-main60.68ms - 61.88msunsure 🔍
-1% - +2%
-0.76ms - +0.98ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local6.68ms - 7.17ms-unsure 🔍
-8% - +2%
-0.60ms - +0.15ms
preact-main6.87ms - 7.43msunsure 🔍
-2% - +9%
-0.15ms - +0.60ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.32ms - 16.58ms-unsure 🔍
-5% - +1%
-0.81ms - +0.11ms
preact-main16.36ms - 17.23msunsure 🔍
-1% - +5%
-0.11ms - +0.81ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.73ms-unsure 🔍
-0% - +0%
-0.02ms - +0.01ms
preact-main3.72ms - 3.74msunsure 🔍
-0% - +1%
-0.01ms - +0.02ms		-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #5281

  • Commit: d3d4182

duration

VersionAvg timevs preact-localvs preact-main
preact-local59.28ms - 60.20ms-unsure 🔍
-1% - +1%
-0.60ms - +0.72ms
preact-main59.21ms - 60.16msunsure 🔍
-1% - +1%
-0.72ms - +0.60ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.99ms - 3.02ms-unsure 🔍
-1% - +0%
-0.02ms - +0.01ms
preact-main3.00ms - 3.02msunsure 🔍
-0% - +1%
-0.01ms - +0.02ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local24.63ms - 25.32ms-unsure 🔍
-1% - +3%
-0.29ms - +0.66ms
preact-main24.46ms - 25.11msunsure 🔍
-3% - +1%
-0.66ms - +0.29ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local30.65ms - 31.47ms-unsure 🔍
-1% - +3%
-0.17ms - +0.99ms
preact-main30.24ms - 31.06msunsure 🔍
-3% - +1%
-0.99ms - +0.17ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local30.53ms - 31.15ms-unsure 🔍
-1% - +2%
-0.18ms - +0.75ms
preact-main30.22ms - 30.89msunsure 🔍
-2% - +1%
-0.75ms - +0.18ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local24.87ms - 25.19ms-unsure 🔍
-1% - +1%
-0.28ms - +0.16ms
preact-main24.94ms - 25.24msunsure 🔍
-1% - +1%
-0.16ms - +0.28ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local26.78ms - 28.18ms-slower ❌
1% - 8%
0.26ms - 2.20ms
preact-main25.57ms - 26.92msfaster ✔
1% - 8%
0.26ms - 2.20ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local20.63ms - 21.13ms-unsure 🔍
-1% - +2%
-0.27ms - +0.42ms
preact-main20.57ms - 21.04msunsure 🔍
-2% - +1%
-0.42ms - +0.27ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 250
  • Built by: CI #5281

  • Commit: d3d4182

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.94ms - 2.12ms-unsure 🔍
-3% - +9%
-0.06ms - +0.18ms
preact-main1.89ms - 2.05msunsure 🔍
-9% - +3%
-0.18ms - +0.06ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.01ms - 1.06ms-unsure 🔍
-1% - +4%
-0.01ms - +0.05ms
preact-main1.00ms - 1.03msunsure 🔍
-4% - +1%
-0.05ms - +0.01ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local31.79ms - 32.60ms-unsure 🔍
-1% - +2%
-0.36ms - +0.52ms
preact-main31.95ms - 32.28msunsure 🔍
-2% - +1%
-0.52ms - +0.36ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.25ms - 1.27ms-unsure 🔍
-3% - +0%
-0.04ms - +0.00ms
preact-main1.26ms - 1.30msunsure 🔍
-0% - +3%
-0.00ms - +0.04ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.32ms - 30.99ms-unsure 🔍
-4% - +4%
-1.16ms - +1.07ms
preact-main29.46ms - 30.93msunsure 🔍
-4% - +4%
-1.07ms - +1.16ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.95ms - 2.97ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms
preact-main2.95ms - 2.96msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Jan 6, 2026 •
edited
Loading

Size Change: +14 B (+0.03%)

Total Size: 47.5 kB

Filename Size Change
dist/preact.js 4.71 kB +11 B (+0.23%)
dist/preact.mjs 4.72 kB +2 B (+0.04%)
dist/preact.umd.js 4.78 kB +1 B (+0.02%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 3.91 kB
compat/dist/compat.mjs 3.84 kB
compat/dist/compat.umd.js 3.96 kB
debug/dist/debug.js 3.91 kB
debug/dist/debug.mjs 3.91 kB
debug/dist/debug.umd.js 3.99 kB
devtools/dist/devtools.js 263 B
devtools/dist/devtools.mjs 273 B
devtools/dist/devtools.umd.js 348 B
hooks/dist/hooks.js 1.53 kB
hooks/dist/hooks.mjs 1.56 kB
hooks/dist/hooks.umd.js 1.6 kB
jsx-runtime/dist/jsxRuntime.js 892 B
jsx-runtime/dist/jsxRuntime.mjs 861 B
jsx-runtime/dist/jsxRuntime.umd.js 966 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jan 6, 2026 •
edited
Loading

Coverage Status

coverage: 99.443%. remained the same
when pulling d3d4182 on strict-equal-vnode-constructor
into bf7a195 on main.

@JoviDeCroock JoviDeCroock merged commit c1bcde3 into main Jan 9, 2026
13 checks passed
@JoviDeCroock JoviDeCroock deleted the strict-equal-vnode-constructor branch January 9, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoviDeCroock @coveralls @rschristian