Skip to content

Conversation

@enapupe
Copy link

@enapupe enapupe commented Jan 10, 2017

related to #492

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.707% when pulling 0211186 on enapupe:width-test-case into bc84e2a on developit:master.

@enapupe enapupe changed the title Add test case that ensures with prop is properly set using setAttribute Add test case that ensures width prop is properly set using setAttribute Jan 10, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.707% when pulling a71a8af on enapupe:width-test-case into bc84e2a on developit:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.707% when pulling 5413d58 on enapupe:width-test-case into dfa5912 on developit:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.707% when pulling 5413d58 on enapupe:width-test-case into dfa5912 on developit:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0a4321e on enapupe:width-test-case into b80bec3 on developit:master.

@enapupe
Copy link
Author

enapupe commented May 29, 2017

Hey!
Today I crossed with this video https://www.youtube.com/watch?v=LY6y3HbDVmg that reminded me I should be using preact in the project that lead me to open this PR.
But months passed and major version later and we still haven't fixed this image with issue?
What the big deal? I mean, I really consider this to be a huge issue since it must affect many people trying to replace react with preact..
What's your PoV here? I'm confused about your goals.

@coveralls
Copy link

coveralls commented Aug 22, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 7d20255 on enapupe:width-test-case into 02f717e on developit:master.

@developit
Copy link
Member

Just an update on this: one of the goals of Preact is to avoid adding additional abstraction over the DOM. It's important that any means of fixing these inconsistencies with React can be accomplished without custom mappings/behavior.

@marvinhagemeister
Copy link
Member

Just checked the spec again and only pixel values are valid for width. Using anything else like percentages is invalid HTML and may lead to rendering differences in different browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants