types: Flesh out HTMLMediaElement types#4705
Conversation
| controlsList?: Signalish<string | undefined>; | ||
| controlslist?: Signalish<'nodownload' | 'nofullscreen' | 'noremoteplayback' | undefined>; | ||
| controlsList?: Signalish<'nodownload' | 'nofullscreen' | 'noremoteplayback' | undefined>; |
There was a problem hiding this comment.
Might be worth altering AllHTMLElements to get all of its properties from IntrinsicElements, eliminating the need to copy from the more per-element interfaces. Will give that a go separately
| playsinline?: Signalish<boolean | undefined>; | ||
| playsInline?: Signalish<boolean | undefined>; |
There was a problem hiding this comment.
These are specific to HTMLVideoElement, they were moved down to that interface.
|
The controlslist attribute allows space separated list of keywords, not a single keyword. So this is perfectly fine: <video
controlsList="nodownload nofullscreen noremoteplayback noplaybackrate"
/>However change introduced here allows adding just a single keyword: References: |
|
Feel free to make a PR switching that back (and possibly another to MDN as the attribute section doesn't seem to mention more than one is allowed at all). |
|
PR: #4744 Indeed, the MDN docs for Video > controlslist are misleading, but quite clear on HTMLMediaElement.controlsList |
Adds some more types & corrects a few for
HTMLMediaElementspecifically