Skip to content

Add missing space in hydration mismatch message#4602

Merged
marvinhagemeister merged 1 commit intopreactjs:mainfrom
sirreal:patch-1
Dec 10, 2024
Merged

Add missing space in hydration mismatch message#4602
marvinhagemeister merged 1 commit intopreactjs:mainfrom
sirreal:patch-1

Conversation

@sirreal
Copy link
Copy Markdown
Contributor

@sirreal sirreal commented Dec 10, 2024

The message reads something like this:

Expected a DOM node of type p but found templateas available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

It should read

Expected a DOM node of type p but found template as available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

"templateas" should be "template as"

-Expected a DOM node of type p but found templateas available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.
+Expected a DOM node of type p but found template as available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

The message reads something like this:

> Expected a DOM node of type p but found templateas available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

It should read

> Expected a DOM node of type p but found template as available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.

```diff
-Expected a DOM node of type p but found templateas available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.
+Expected a DOM node of type p but found template as available DOM-node(s), this is caused by the SSR'd HTML containing different DOM-nodes compared to the hydrated one.
```
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 99.617%. remained the same
when pulling d2904b9 on sirreal:patch-1
into 5c9625a on preactjs:main.

@marvinhagemeister marvinhagemeister merged commit eba80f7 into preactjs:main Dec 10, 2024
@sirreal sirreal deleted the patch-1 branch December 10, 2024 17:27
@JoviDeCroock JoviDeCroock mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants