Skip to content

types: Re-add missing properties & property casings#4554

Merged
rschristian merged 2 commits intomainfrom
fix/missing-prop-casing
Nov 12, 2024
Merged

types: Re-add missing properties & property casings#4554
rschristian merged 2 commits intomainfrom
fix/missing-prop-casing

Conversation

@rschristian
Copy link
Copy Markdown
Member

There are now only 4 properties from AllHTMLAttributes that do not exist in HTMLAttributes & all the per-element interfaces:

  • contextMenu/contextmenu
    • Was added in the original batch of types 6 years ago and marked deprecated then. Since then, the MDN page documenting it, which we had in our deprecation comment, has been removed entirely. Seems like a good candidate for removal.
  • icon, manifest, radioGroup
    • I can find no mention of these attributes/properties existing and all were added in the original batch of types 6 years ago. As such, I'm guessing they were mistakes.
    • There is, however, a radiogroup aria role. I'm guessing that's where it came from at least.

Now this doesn't quite guarantee all types are correct, because of the split interfaces we may still need to copy types to elements that are missing them, but all types do at least exist somewhere in the new set. Additionally, we do appear to have about 25 new prop/attr types as well that we were missing in core previously.

@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 99.488%. remained the same
when pulling 1835c8d on fix/missing-prop-casing
into e7610ef on main.

@rschristian rschristian merged commit bedd413 into main Nov 12, 2024
@rschristian rschristian deleted the fix/missing-prop-casing branch November 12, 2024 01:05
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants