Merged
Conversation
rschristian
approved these changes
Nov 10, 2024
Member
rschristian
left a comment
There was a problem hiding this comment.
Think we just need to bump our TS devDep to 5.1 and we should be good
d8ce9c5 to
6b8cb6d
Compare
rschristian
reviewed
Nov 11, 2024
ad5e475 to
7dcff34
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TypeScript 5.1 there was a change to the JSX types, to support this properly we'll need to fork our types in pre and post this minor version.
I'm pretty unsure whether we can add tests for this in our repository 😅
Resolves #4113
Resolves #4425
Resolves #3611
Resolves #3815
Enables #4481
Supersedes #3482