Skip to content

React 18 hooks#3568

Merged
marvinhagemeister merged 10 commits intomasterfrom
redo-hooks
Jun 29, 2022
Merged

React 18 hooks#3568
marvinhagemeister merged 10 commits intomasterfrom
redo-hooks

Conversation

@JoviDeCroock
Copy link
Copy Markdown
Member

This implements stub-like behaviour for most hooks and implements a minimal functional version for others, currently we are missing useId, this is a bigger piece of work as it will need changes in RenderToString/... to work #3402 implements the CSR version of it.

Resolves #3557
Resolves #3555

@JoviDeCroock JoviDeCroock requested a review from developit June 15, 2022 15:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 15, 2022

Size Change: +468 B (1%)

Total Size: 43.4 kB

Filename Size Change
compat/dist/compat.js 3.64 kB +156 B (4%)
compat/dist/compat.module.js 3.62 kB +149 B (4%)
compat/dist/compat.umd.js 3.7 kB +163 B (4%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 3 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 307 B 0 B
dist/preact.js 4.03 kB 0 B
dist/preact.min.js 4.06 kB 0 B
dist/preact.module.js 4.05 kB 0 B
dist/preact.umd.js 4.1 kB 0 B
hooks/dist/hooks.js 1.25 kB 0 B
hooks/dist/hooks.module.js 1.26 kB 0 B
hooks/dist/hooks.umd.js 1.33 kB 0 B
jsx-runtime/dist/jsxRuntime.js 317 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 327 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 395 B 0 B
test-utils/dist/testUtils.js 444 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 521 B 0 B

compressed-size-action

@coveralls
Copy link
Copy Markdown

coveralls commented Jun 15, 2022

Coverage Status

Coverage increased (+0.007%) to 99.454% when pulling 557a8e4 on redo-hooks into 8a1cbd4 on master.

@JLucasCAmorim
Copy link
Copy Markdown

Hello guys! When will it be merged?

Copy link
Copy Markdown
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Let's get the ball rolling with adding these stubs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: startTransition is not a function Query on support with React 18

4 participants