Skip to content

Compat Optimizations (v11 backport)#2752

Merged
marvinhagemeister merged 3 commits into
masterfrom
compat-optimizations
Sep 12, 2020
Merged

Compat Optimizations (v11 backport)#2752
marvinhagemeister merged 3 commits into
masterfrom
compat-optimizations

Conversation

@developit

@developit developit commented Sep 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This is a backport of the compat size/perf optimizations I did for v11 in #2742.

@github-actions

github-actions Bot commented Sep 11, 2020 •
edited
Loading

Copy link
Copy Markdown

Size Change: -393 B (0%)

Total Size: 40.1 kB

Filename Size Change
compat/dist/compat.js 3.14 kB -126 B (4%)
compat/dist/compat.module.js 3.15 kB -136 B (4%)
compat/dist/compat.umd.js 3.2 kB -131 B (4%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.09 kB 0 B
debug/dist/debug.module.js 3.09 kB 0 B
debug/dist/debug.umd.js 3.18 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 3.93 kB 0 B
dist/preact.min.js 3.96 kB 0 B
dist/preact.module.js 3.96 kB 0 B
dist/preact.umd.js 4 kB 0 B
hooks/dist/hooks.js 1.1 kB 0 B
hooks/dist/hooks.module.js 1.12 kB 0 B
hooks/dist/hooks.umd.js 1.18 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@developit
This is a backport of the compat optimizations I did for v11 in #2742.
30e54f4 
Signed-off-by: Jason Miller <developit@users.noreply.github.com>
@developit

developit commented Sep 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member Author

Context for the loose inequality: 750189b #327

@coveralls

coveralls commented Sep 11, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 100.0% when pulling d75c3f2 on compat-optimizations into 84a16f2 on master.

@developit developit marked this pull request as ready for review September 12, 2020 03:42
marvinhagemeister
marvinhagemeister approved these changes Sep 12, 2020
View reviewed changes

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! 🙌

@marvinhagemeister marvinhagemeister merged commit 9aa7d38 into master Sep 12, 2020
@marvinhagemeister marvinhagemeister deleted the compat-optimizations branch September 12, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@developit @coveralls @marvinhagemeister @JoviDeCroock