Skip to content

Add length check for deps array#2729

Merged
marvinhagemeister merged 2 commits into
masterfrom
JoviDeCroock-patch-1
Aug 30, 2020
Merged

Add length check for deps array#2729
marvinhagemeister merged 2 commits into
masterfrom
JoviDeCroock-patch-1

Conversation

@JoviDeCroock

@JoviDeCroock JoviDeCroock commented Aug 30, 2020

Copy link
Copy Markdown
Member

Fixes #2728

@github-actions

github-actions Bot commented Aug 30, 2020

Copy link
Copy Markdown

Size Change: +25 B (0%)

Total Size: 40.4 kB

Filename Size Change
hooks/dist/hooks.js 1.1 kB +9 B (0%)
hooks/dist/hooks.module.js 1.12 kB +8 B (0%)
hooks/dist/hooks.umd.js 1.18 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.26 kB 0 B
compat/dist/compat.module.js 3.29 kB 0 B
compat/dist/compat.umd.js 3.33 kB 0 B
debug/dist/debug.js 3.09 kB 0 B
debug/dist/debug.module.js 3.09 kB 0 B
debug/dist/debug.umd.js 3.18 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 195 B 0 B
devtools/dist/devtools.umd.js 261 B 0 B
dist/preact.js 3.91 kB 0 B
dist/preact.min.js 3.93 kB 0 B
dist/preact.module.js 3.93 kB 0 B
dist/preact.umd.js 3.97 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock marked this pull request as ready for review August 30, 2020 11:57

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🙌

@github-actions

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.804% when pulling a414d6e on JoviDeCroock-patch-1 into 0e99976 on master.

@marvinhagemeister marvinhagemeister merged commit f31a6de into master Aug 30, 2020
@marvinhagemeister marvinhagemeister deleted the JoviDeCroock-patch-1 branch August 30, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

useMemo doesn't correctly detect deps changes

2 participants