Skip to content

fix rendering children as zero number#2725

Merged
JoviDeCroock merged 4 commits into
preactjs:masterfrom
JiLiZART:fix/children-map-zero
Aug 28, 2020
Merged

fix rendering children as zero number#2725
JoviDeCroock merged 4 commits into
preactjs:masterfrom
JiLiZART:fix/children-map-zero

Conversation

@JiLiZART

Copy link
Copy Markdown
Contributor

React allows pass 0 (number, not string) as children prop and properly render it
React sandbox example
https://codesandbox.io/s/cranky-dust-7tjqw

@coveralls

coveralls commented Aug 28, 2020

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 99.804% when pulling ec5f4f2 on JiLiZART:fix/children-map-zero into 952a7e2 on preactjs:master.

Comment thread compat/src/Children.js Outdated
@JiLiZART JiLiZART requested a review from JoviDeCroock August 28, 2020 15:51
Comment thread compat/src/Children.js Outdated
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>

@JoviDeCroock JoviDeCroock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much! 💯

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you so much for the PR 🙌

@JoviDeCroock JoviDeCroock merged commit 0e99976 into preactjs:master Aug 28, 2020
@JiLiZART JiLiZART deleted the fix/children-map-zero branch August 28, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants