Avoid assigning to readonly style#2723
Merged
Merged
Conversation
… old browsers which results in an exception
marvinhagemeister
approved these changes
Aug 28, 2020
marvinhagemeister
left a comment
Member
There was a problem hiding this comment.
Good catch! I recall us having assigned to cssText earlier in our code base 👍
|
Size Change: +22 B (0%) Total Size: 40.4 kB
ℹ️ View Unchanged
|
|
this causes IE11 to fail making preact 10.4.7 and 10.4.8 incompatible with IE11. |
Member
Author
|
@klh no this fixes that, this PR is aimed at fixing the linked issue which is what you're describing. This is currently unpublished |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2722
@charlier if you get the chance you can use our pika-distribution (one of the PR-checks) to see if it works locally for you.