Rename useMemo _callback to _factory (+0 B)#2131
Merged
Merged
Conversation
andrewiggins
commented
Nov 15, 2019
| */ | ||
| export function useMemo<T>(factory: () => T, inputs?: Inputs): T; | ||
| // for `inputs`, allow undefined, but don't make it optional as that is very likely a mistake | ||
| export function useMemo<T>(factory: () => T, inputs: Inputs | undefined): T; |
Member
Author
There was a problem hiding this comment.
I copied this from the react types for useMemo
JoviDeCroock
approved these changes
Nov 15, 2019
marvinhagemeister
approved these changes
Nov 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While re-reading this code, the name
_callbackkept tripping me up because I thought it was something that needed to be invoked after some asynchronous event. But then I realized I was just misunderstanding this parameter. So I thought I'd rename it to something that more explicitly states the intention of what this parameter is: a factory that produces a value we remember.This PR also includes an improvement to useMemo types I copied from DefinitelyTyped (link in comments)
Thoughts?