Skip to content

Fix cross browser tests assertions#2127

Merged
andrewiggins merged 5 commits into
masterfrom
fix/master-sauce-tests
Nov 15, 2019
Merged

Fix cross browser tests assertions#2127
andrewiggins merged 5 commits into
masterfrom
fix/master-sauce-tests

Conversation

@andrewiggins

Copy link
Copy Markdown
Member

Our sauce tests on master have been failing for a little while. This PR fixes them, meaning the size report from Travis builds should start working again. I think that plugin compares against the last known good build on master, and since that is really old, it hasn't been reporting meaningful size comparisons.

@coveralls

coveralls commented Nov 14, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 100.0% when pulling 46b7982 on fix/master-sauce-tests into dad5d96 on master.

@JoviDeCroock JoviDeCroock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Andre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants