Skip to content

Remove redundant if clause in suspense _catchError#2119

Merged
sventschui merged 1 commit into
masterfrom
improvement/simplify-suspense-catch-error
Nov 13, 2019
Merged

Remove redundant if clause in suspense _catchError#2119
sventschui merged 1 commit into
masterfrom
improvement/simplify-suspense-catch-error

Conversation

@sventschui

Copy link
Copy Markdown
Member

Remove redundant if clause in suspense _catchError

As mentioned in Slack this condition is already present on line 6

=> -4B in compat

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.1%) to 100.0% when pulling 8d93dc3 on improvement/simplify-suspense-catch-error into d16f15c on master.

@JoviDeCroock JoviDeCroock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot! 💯

@cristianbote cristianbote left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 good catch!

@sventschui sventschui merged commit 9764924 into master Nov 13, 2019
@sventschui sventschui deleted the improvement/simplify-suspense-catch-error branch November 13, 2019 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants