Add test to cover hooks debug helper#2115
Merged
Merged
Conversation
marvinhagemeister
approved these changes
Nov 12, 2019
marvinhagemeister
left a comment
Member
There was a problem hiding this comment.
Super awesome 🙌
P.S.: Noticed the same about travis not always completing builds...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings our statement and line code coverage to 100% which should prevent coveralls from saying code coverage decreased on PRs that reduce the number of lines (e.g. 989/990 < 997/998, but no longer! 989/989 == 998/998)
After this PR goes in, if coveralls says that code coverage decreased then that means it actually did, and you should probably double check your tests cases are comprehensive.
P.S. Occasionally, I've seen Travis not run our complete test suite, so if you see coverage drop, that could also be a reason. Restarting the travis build should fix it.