Add test for lifecycles and state of a delayed suspending compo…#2114
Merged
Conversation
marvinhagemeister
approved these changes
Nov 12, 2019
andrewiggins
commented
Nov 13, 2019
| // TODO: This is called thrice since the cDU queued up after the second | ||
| // increment is never cleared once the component suspends. So when it | ||
| // resumes and the component is rerendered, we queue up another cDU so | ||
| // cDU is called an extra time. |
Member
Author
There was a problem hiding this comment.
Note there is a follow up to this comment in #2098 (specifically this comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new test covers the case where a component suspends after the first where some state change causes the suspension (e.g. a button press that asynchronously increments the count when it needs to get more values then it has. Actually, that's a good test case. Lol maybe sometime later I'll add that).