Skip to content

Add _depth to mangle.json#1542

Merged
marvinhagemeister merged 3 commits into
preactjs:masterfrom
38elements:patch-1
Apr 17, 2019
Merged

Add _depth to mangle.json#1542
marvinhagemeister merged 3 commits into
preactjs:masterfrom
38elements:patch-1

Conversation

@38elements

Copy link
Copy Markdown
Contributor

@JoviDeCroock

JoviDeCroock commented Apr 17, 2019

Copy link
Copy Markdown
Member

This seems to add 2 bytes to core, any reason as to why that mangling is added?

@38elements

Copy link
Copy Markdown
Contributor Author

Thank you for comment.
I thought this change is necessary to keep consistent property name.
I think this change is unnecessary.

@38elements 38elements closed this Apr 17, 2019
@marvinhagemeister

Copy link
Copy Markdown
Member

@38elements Thanks for the PR, you're right that we should add it to our mangle file to avoid any potential name clashes of class properties 👍

@JoviDeCroock it probably adds 2 bytes because the name is a bit longer than a single char.

@38elements 38elements reopened this Apr 17, 2019
@38elements

Copy link
Copy Markdown
Contributor Author

Thank you for comment.
Since Changing __b is +1B, __b is better than __D.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling f0db0b4 on 38elements:patch-1 into 1e8c813 on developit:master.

@marvinhagemeister marvinhagemeister left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍 👍

@marvinhagemeister marvinhagemeister merged commit 1c2c7bd into preactjs:master Apr 17, 2019
@38elements 38elements deleted the patch-1 branch April 17, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants