Fix stale DOM with async preact-router#1539
Merged
Merged
Conversation
JoviDeCroock
approved these changes
Apr 14, 2019
JoviDeCroock
left a comment
Member
There was a problem hiding this comment.
Small changes with lots of benefit, is there something you can't love about PR's like these? :D Great job yet again. You're on 🔥
b6fa4f1 to
5289e54
Compare
5289e54 to
3914769
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that is most noticeable with the
Asynccomponent in our cli. The issue is that the previous page is not unmounted correctly when switching routes. When this happens the vnode's_domproperty is wrong. The changes fix this problem, but I still haven't found a way to turn it into a decent test case.Adds
+1 B🎉EDIT: Found a test case that reproduces the exact issue 🎉