Skip to content

Fix Portals not being unmounted#1537

Merged
marvinhagemeister merged 1 commit into
masterfrom
unmount_portals
Apr 13, 2019
Merged

Fix Portals not being unmounted#1537
marvinhagemeister merged 1 commit into
masterfrom
unmount_portals

Conversation

@marvinhagemeister

Copy link
Copy Markdown
Member

Fixes #1535 .
Adds +17 B to compat.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 741bd51 on unmount_portals into c91f8ac on master.

@JoviDeCroock JoviDeCroock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Also a needed fix before beta :D nice work

@marvinhagemeister marvinhagemeister merged commit 915a3ae into master Apr 13, 2019
@marvinhagemeister marvinhagemeister deleted the unmount_portals branch April 13, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[10.0.0-alpha.4] preact/compat createPortal does not perform like React

3 participants