(tests) - act should be able to track and flush the full queue and all subsequent queues#1520
Merged
Conversation
Member
|
Great. I ran into this recently and had to implement a utility as a workaround. I'll try to test this out locally and see if it resolves the issue in my case. |
Member
Author
|
@robertknight that would be awesome, please do! It works for the case I ran into, if you find another one just hit me up and we can add it in tests. |
marvinhagemeister
approved these changes
Apr 12, 2019
marvinhagemeister
left a comment
Member
There was a problem hiding this comment.
LGTM, it's getting better and better 👍 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reasoning about our current testing approach I found a critical flaw. What happens when for example you type in an input -> this triggers a validation -> this sets state. A series of hooks get executed and well our current approach in act has no way of following these up.
This is why I introduced a global array in options, named effects. Every queued effect will be pushed and will be removed when we're invoking/cleaning up. This makes for a consistent testing method.