TS: Use same type naming as @types/react#1519
Merged
Merged
Conversation
Member
|
Maybe we need to export them as an alias, so that we stay backwards compatible for people relying on the old names? Or just reexport them from compat since we guarantee react compat there |
Member
Author
|
True, this is a breaking change and we should make the transition as smooth as possible 👍 |
aa97f7e to
979847d
Compare
JoviDeCroock
approved these changes
Apr 7, 2019
JoviDeCroock
left a comment
Member
There was a problem hiding this comment.
Nice job, I don't think we should impose breaking changes in types just now happy to see we agree . Good work 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes copy & pasting react components that are written in TypeScript easier.
Fixes #1518 .